Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indexes to numeric street location fields and remove from street string location fields. #2692

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

ziv17
Copy link
Collaborator

@ziv17 ziv17 commented Aug 29, 2024

Closes #2691

@ziv17 ziv17 marked this pull request as ready for review August 29, 2024 17:45
@ziv17 ziv17 requested a review from atalyaalon August 29, 2024 17:45
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.60%. Comparing base (400af13) to head (32263e5).
Report is 86 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2692      +/-   ##
==========================================
- Coverage   53.22%   52.60%   -0.63%     
==========================================
  Files         119      122       +3     
  Lines        9924    10157     +233     
==========================================
+ Hits         5282     5343      +61     
- Misses       4642     4814     +172     
Flag Coverage Δ
unittests 52.60% <ø> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ziv17 ziv17 force-pushed the 2691-add-indexes branch from 3e42d08 to 32263e5 Compare August 30, 2024 16:00
@atalyaalon atalyaalon merged commit b55f948 into data-for-change:dev Sep 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve performance of cache calculation
3 participants