Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safety data schema #2735

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Conversation

ziv17
Copy link
Collaborator

@ziv17 ziv17 commented Dec 13, 2024

Please review the suggested schema. If the direction is OK I will prepare poc tables and prepare POC of the /involved (replacing the /accidents) query.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 81.39535% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.75%. Comparing base (400af13) to head (005fee4).
Report is 148 commits behind head on dev.

Files with missing lines Patch % Lines
anyway/flask_app.py 20.00% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2735      +/-   ##
==========================================
- Coverage   53.22%   52.75%   -0.47%     
==========================================
  Files         119      122       +3     
  Lines        9924    10256     +332     
==========================================
+ Hits         5282     5411     +129     
- Misses       4642     4845     +203     
Flag Coverage Δ
unittests 52.75% <81.39%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ziv17 ziv17 force-pushed the safety-data-schema branch from e9cc41d to 005fee4 Compare December 23, 2024 18:10
@ziv17
Copy link
Collaborator Author

ziv17 commented Dec 23, 2024

Hi @atalyaalon , @citizen-dror ,
I added initial involved and accidents tables, and sample code that loads some data to the tables, and a simple query. The vehicles is not there yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants