Correct typo in mimetype variable #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add DarkMauve and DarkFlagshipTerrastruct as explicit theme options
DarkMauve was already in the theme list
Also: - Adds is_nonempty_string helper function - Appends random number for diagram file name - Use d2 file extension not txt for input - Allow alternate syntax for attribute classes on code blocks
Also: - Add support for reading d2 diagrams from external files using `file` parameter. Block text is ignored if file parameter is supplied. - Add support for alternate code block syntax without curly braces. - Insert rendered diagrams into the Pandoc mediabag when `embed_type="link"` - Refactor to add helper functions `setPreD2RenderOptions` and `setD2RenderFormat`
Also - add animate_interval parameter - drop setD2RenderFormat helper function - use quarto.project.output_directory to set default folder - revise check for d2 code block class - replace codeblock text if file is provided - add support for tala layout
Also: - add check to see if file exists - Improve handling of code block formatting (when echo=true) - remove duplicative processing for options.pad and options.animate_interval
Also add external d2 file to test file argument
Also reorder early return when file + cb text are nil
Also: - Simplify flow for setting mimetype - rename setPreD2RenderOptions to setD2Options - Protect against filename values w/ file extension - Use assert consistently for errors - Simplify flow for returning data or outputPath
Also fixes issue w/ broken links inside Quarto projects + error outside of Quarto projects
rcannood
approved these changes
Apr 3, 2024
|
Awesome, thanks @rcannood. For your interest, I decided to start putting together a stand-alone R package with the goal of creating a custom knitr engine https://elipousson.github.io/d2r/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename setPreD2RenderOptions helper to setD2Options and add setD2outputPath helper.
Also fix bug impacting diagrams when embed mode is linking and document is inside an RStudio Project