[M1466] Offline Toggle Components (with test) + Refresh project (UI only) #21
Conversation
| import Switch from 'react-switch' | ||
|
|
||
| /** | ||
| * Describe your component |
There was a problem hiding this comment.
Would you rather remove the component description or add a description? In this case, does the component name do a good enough job?
| boxShadow="0px 1px 5px rgba(0, 0, 0, 0.6)" | ||
| activeBoxShadow="0px 0px 1px 10px rgba(0, 0, 0, 0.2)" | ||
| uncheckedIcon={false} | ||
| /> |
There was a problem hiding this comment.
I feel strongly against styling via props in return statements/markup. Ok for prototypes, not ideal for maintainable code.
Im going to do a quick foray into how hard it would be to roll out own toggle component, to see if thats a cost effective option here. (have never done).
There was a problem hiding this comment.
Also going to check if we can style react-switch via styled components as a option
There was a problem hiding this comment.
K, this is what I came up with #22
| ...utils, | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
It goes against a lot of what we are taught as devs, but its best to avoid the DRY principle in tests. I'd remove the setup function here.
|
Used alternative one, close this |
|
Just reopening to because alternate had this branch and the merge target instead of |
No description provided.