Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build containers for both archs in single job #272

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

masih
Copy link
Contributor

@masih masih commented Sep 6, 2023

Use a single build step to build for both architectures. Context:
investigating images overriding each other on ghcr.

Use a single build step to build for both architectures. Context:
 investigating images overriding each other on ghcr.
@masih masih requested a review from xinaxu September 6, 2023 08:00
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (ecc2746) 65.02% compared to head (251b931) 64.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
- Coverage   65.02%   64.99%   -0.04%     
==========================================
  Files         137      137              
  Lines        8044     8044              
==========================================
- Hits         5231     5228       -3     
- Misses       2106     2108       +2     
- Partials      707      708       +1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@masih masih requested a review from willscott September 6, 2023 08:20
@masih masih merged commit 9b8457a into main Sep 6, 2023
@masih masih deleted the masih/container-build-arch-single branch September 6, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants