Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix godoc formatting #314

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Fix godoc formatting #314

merged 1 commit into from
Sep 14, 2023

Conversation

xinaxu
Copy link
Contributor

@xinaxu xinaxu commented Sep 14, 2023

  • Fix everywhere that does not use correct padding for godoc bullet list.
  • storage gen now no longer generates exported functions

@xinaxu xinaxu marked this pull request as ready for review September 14, 2023 07:51
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05% ⚠️

Comparison is base (9c42d43) 73.94% compared to head (fd65aaa) 73.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
- Coverage   73.94%   73.89%   -0.05%     
==========================================
  Files         130      130              
  Lines        8065     8065              
==========================================
- Hits         5964     5960       -4     
- Misses       1473     1475       +2     
- Partials      628      630       +2     
Files Changed Coverage Δ
analytics/analytics.go 67.30% <ø> (ø)
api/api.go 74.15% <ø> (ø)
docs/swagger/docs.go 100.00% <ø> (ø)
handler/admin/init.go 57.14% <ø> (ø)
handler/admin/reset.go 45.45% <ø> (ø)
handler/dataprep/create.go 69.31% <ø> (ø)
handler/dataprep/explore.go 72.36% <ø> (ø)
handler/dataprep/list.go 100.00% <ø> (ø)
handler/dataprep/listschedules.go 78.57% <ø> (ø)
handler/dataprep/output.go 72.72% <ø> (ø)
... and 51 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinaxu xinaxu merged commit 753cdba into main Sep 14, 2023
@xinaxu xinaxu deleted the xinaxu/godoc-format branch September 14, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant