Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry for IO read error #332

Merged
merged 4 commits into from
Sep 17, 2023
Merged

Retry for IO read error #332

merged 4 commits into from
Sep 17, 2023

Conversation

xinaxu
Copy link
Contributor

@xinaxu xinaxu commented Sep 16, 2023

Offers simple retry strategy for IO read error.

   Retry Strategy
   --client-retry-backoff value      The constant delay backoff for retrying IO read errors (default: 1s)
   --client-retry-backoff-exp value  The exponential delay backoff for retrying IO read errors (default: 1.0)
   --client-retry-delay value        The initial delay before retrying IO read errors (default: 1s)
   --client-retry-max value          Max number of retries for IO read errors (default: 10)

resolves #327

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Patch coverage: 70.33% and project coverage change: +0.04% 🎉

Comparison is base (3baaef8) 73.78% compared to head (6344bb7) 73.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   73.78%   73.82%   +0.04%     
==========================================
  Files         136      136              
  Lines        8555     8665     +110     
==========================================
+ Hits         6312     6397      +85     
- Misses       1577     1594      +17     
- Partials      666      674       +8     
Files Changed Coverage Δ
docs/swagger/docs.go 100.00% <ø> (ø)
handler/storage/update.go 72.50% <0.00%> (-8.06%) ⬇️
storagesystem/rclone.go 78.85% <64.61%> (-6.44%) ⬇️
cmd/download.go 92.20% <100.00%> (+0.10%) ⬆️
cmd/storage/create.go 87.14% <100.00%> (+1.42%) ⬆️
cmd/storage/update.go 78.57% <100.00%> (+2.67%) ⬆️
model/basetypes.go 69.94% <100.00%> (+5.96%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinaxu xinaxu merged commit a1977e5 into main Sep 17, 2023
@xinaxu xinaxu deleted the xinaxu/retry-read branch September 17, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retry on failed Rclone stream from last offset
1 participant