Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to skip inaccessible file #334

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Allow to skip inaccessible file #334

merged 4 commits into from
Sep 19, 2023

Conversation

xinaxu
Copy link
Contributor

@xinaxu xinaxu commented Sep 19, 2023

Added a flag to skip inaccessible file
Inaccessible file are files that are included in scanning and listing but cannot be opened.
Examples:

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 84.21% and project coverage change: +0.42% 🎉

Comparison is base (a1977e5) 73.81% compared to head (df3230e) 74.24%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   73.81%   74.24%   +0.42%     
==========================================
  Files         136      137       +1     
  Lines        8665     8793     +128     
==========================================
+ Hits         6396     6528     +132     
+ Misses       1595     1594       -1     
+ Partials      674      671       -3     
Files Changed Coverage Δ
docs/swagger/docs.go 100.00% <ø> (ø)
handler/storage/update.go 70.73% <0.00%> (-1.77%) ⬇️
pack/pack.go 69.76% <72.72%> (+3.36%) ⬆️
cmd/storage/create.go 87.41% <100.00%> (+0.26%) ⬆️
cmd/storage/update.go 79.06% <100.00%> (+0.49%) ⬆️
model/basetypes.go 70.45% <100.00%> (+0.51%) ⬆️
pack/assembler.go 83.42% <100.00%> (+2.28%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinaxu xinaxu merged commit 88c011e into main Sep 19, 2023
@xinaxu xinaxu deleted the xinaxu/skip-inaccessible branch September 19, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow skipping inaccessible files both during scanning and during reading
1 participant