Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag to force sending out deal #393

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Flag to force sending out deal #393

merged 1 commit into from
Oct 19, 2023

Conversation

xinaxu
Copy link
Contributor

@xinaxu xinaxu commented Oct 19, 2023

resolves #364

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2775d73) 73.91% compared to head (d977132) 73.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   73.91%   73.95%   +0.04%     
==========================================
  Files         147      147              
  Lines        9614     9631      +17     
==========================================
+ Hits         7106     7123      +17     
- Misses       1767     1768       +1     
+ Partials      741      740       -1     
Files Coverage Δ
cmd/deal/schedule/create.go 76.19% <100.00%> (+0.38%) ⬆️
cmd/deal/schedule/update.go 85.36% <100.00%> (+0.55%) ⬆️
docs/swagger/docs.go 100.00% <ø> (ø)
handler/deal/schedule/create.go 89.51% <100.00%> (+0.08%) ⬆️
handler/deal/schedule/update.go 91.54% <100.00%> (+0.18%) ⬆️
model/replication.go 100.00% <ø> (ø)
service/dealpusher/dealpusher.go 73.22% <100.00%> (+0.64%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinaxu xinaxu merged commit 4077d58 into main Oct 19, 2023
@xinaxu xinaxu deleted the xinaxu/force-send-deal branch October 19, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deal making should have --force flag to skip checking replica count
1 participant