adds first version of timeline snapping, with a button to enable it #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and snapping added for steps, VA/NVA, and walking/standing, with a 10px tolerance
hobinjk-dts
reviewed
Oct 9, 2025
src/motionStudy/timeline.js
Outdated
| } | ||
|
|
||
| // Returns the start/end times of colored regions in the poses - with similar logic as in drawSpaghettiPoses | ||
| getPoseBreakTimestamps(poses) { |
There was a problem hiding this comment.
I think instead of duplicating the logic it would be better to store an array of lastBreakTimestamps in drawSpaghettiPoses
There was a problem hiding this comment.
Good idea! And thanks for catching that bug. I'll fix those
There was a problem hiding this comment.
I think you missed editing this one, the above getWalkStandSnappableTimes looks good though!
There was a problem hiding this comment.
Oops, forgot to delete that after swapping away from using it
…d end of entire timeline
|
Does this fix it for you? I fixed a couple of small bugs but I'm not sure if it covers the same one you were experiencing. |
hobinjk-dts
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapping added for steps, VA/NVA, and walking/standing, with a 10px tolerance
Still need to add snapping for ergonomics peaks, but that can probably be done in a follow up