Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: NumberController + mouseWheel #166

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

avkudr
Copy link

@avkudr avkudr commented Dec 18, 2017

Hello

First of all, thank you for your amazing work!

I've just added a new feature to allow the modification of the value in NumberController using mouse wheel. Scrolling up increments the value by the step defined by user, scrolling down makes the inverse.
The mouse cursor should be over the parameter you want to modify.

Actually, I needed this feature to be able to smoothly modify the values of NumberController without writing explicitly the new value and do it fast. I found that it is quite complicated to do with mouse dragging when the interval of change is big (line [-200;200]) and the step is small (0.25 for example).

I tested the code in:

  • Firefox 57.0.1
  • Chrome 53.0.3239.108
    All tests in "tests/index.html" are passed :)

New dependency: "jquery-mousewheel"

Pull request contains also the rebuilt distribution files with this change.

@donmccurdy
Copy link
Contributor

Thanks @Argon24! Would the wheel event work in all browsers? It's supposed to be available in IE9+.

And, could you remove the build/* files from this PR? They'll be updated automatically with each version release.

@avkudr
Copy link
Author

avkudr commented Dec 19, 2017

I've done new tests with:

  • Safari 11.0.1 (13604.3.5)
  • Microsoft Edge 40.15063.674.0
  • Internet Explorer 11.786.15063.0
    Everything works fine.

I've also deleted files from build/*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants