Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle SET ROLE properly #304

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

flaneur2020
Copy link
Member

this PR handles the SessionState as a whole:

  1. on starting each query, it send the SessionState to the query instance
  2. query instance responses a new SessionState to the client, and the client just save it
  3. client pick the reponded SessionState to the next query

this may help reduce the cognize load when adding things into the SessionState, do not need handle_session() and make_session() with understanding of the fields, all we need is to pass it as a whole.

@flaneur2020 flaneur2020 changed the title refactor: handle SessionState as a whole fix: handle SET ROLE properly Nov 15, 2023
@flaneur2020 flaneur2020 marked this pull request as ready for review November 15, 2023 13:02
@everpcpc everpcpc merged commit 4394aa2 into databendlabs:main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants