Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add frontend CI and release steps #486

Merged
merged 27 commits into from
Oct 25, 2024
Merged

Conversation

Maricaya
Copy link
Contributor

@Maricaya Maricaya commented Oct 20, 2024

This pull request adds steps to build the frontend in the GitHub Actions workflow. It includes:

  • Frontend build process using yarn.
  • Ensures the frontend files (HTML, CSS, JS, SVG) are uploaded and included in the release.

These changes help make sure that the frontend is always up-to-date and part of the release.

@Maricaya
Copy link
Contributor Author

Hi @sundy-li, can you tell me how to test the release ci on local?

@sundy-li
Copy link
Member

sundy-li commented Oct 24, 2024

Hi @sundy-li, can you tell me how to test the release ci on local?

I think we should bind the HTML files into bendsql/cli package.

Maybe you can try https://github.com/pyrossh/rust-embed or just use include_bytes! macro.

@Maricaya Maricaya marked this pull request as ready for review October 24, 2024 22:28
@Maricaya
Copy link
Contributor Author

Hi @sundy-li, can you tell me how to test the release ci on local?

I think we should bind the HTML files into bendsql/cli package.

Maybe you can try https://github.com/pyrossh/rust-embed or just use include_bytes! macro.

Thanks so much for your help! I now have a much better understanding of how to build the frontend files and integrate them into the Rust project. I've already made the changes in this PR. Please take a look when you have a moment. Thanks again!😊

@sundy-li sundy-li merged commit 9030055 into databendlabs:main Oct 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants