Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support display spill file stats #565

Merged
merged 4 commits into from
Jan 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bindings/nodejs/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,11 @@ impl ServerStats {
self.0.write_bytes
}

#[napi(getter)]
pub fn spill_file_nums(&self) -> usize {
self.0.spill_file_nums
}

#[napi(getter)]
pub fn running_time_ms(&self) -> f64 {
self.0.running_time_ms
Expand Down
4 changes: 4 additions & 0 deletions bindings/python/src/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,10 @@ impl ServerStats {
self.0.write_bytes
}
#[getter]
pub fn spill_file_nums(&self) -> usize {
self.0.spill_file_nums
}
#[getter]
pub fn running_time_ms(&self) -> f64 {
self.0.running_time_ms
}
Expand Down
26 changes: 22 additions & 4 deletions cli/src/display.rs
Original file line number Diff line number Diff line change
Expand Up @@ -410,23 +410,41 @@ impl ChunkDisplay for FormatDisplay<'_> {

fn format_read_progress(ss: &ServerStats, elapsed: f64) -> String {
format!(
"Processing {}/{} ({} rows/s), {}/{} ({}/s)",
"Processing {}/{} ({} rows/s), {}/{} ({}/s){}",
humanize_count(ss.read_rows as f64),
humanize_count(ss.total_rows as f64),
humanize_count(ss.read_rows as f64 / elapsed),
HumanBytes(ss.read_bytes as u64),
HumanBytes(ss.total_bytes as u64),
HumanBytes((ss.read_bytes as f64 / elapsed) as u64)
HumanBytes((ss.read_bytes as f64 / elapsed) as u64),
if ss.spill_file_nums > 0 {
format!(
", spilled {} files, {}",
ss.spill_file_nums,
HumanBytes(ss.spill_bytes as u64)
)
} else {
"".to_string()
}
)
}

pub fn format_write_progress(ss: &ServerStats, elapsed: f64) -> String {
format!(
"Written {} ({} rows/s), {} ({}/s)",
"Written {} ({} rows/s), {} ({}/s){}",
humanize_count(ss.write_rows as f64),
humanize_count(ss.write_rows as f64 / elapsed),
HumanBytes(ss.write_bytes as u64),
HumanBytes((ss.write_bytes as f64 / elapsed) as u64)
HumanBytes((ss.write_bytes as f64 / elapsed) as u64),
if ss.spill_file_nums > 0 {
format!(
", spilled {} files, {}",
ss.spill_file_nums,
HumanBytes(ss.spill_bytes as u64)
)
} else {
"".to_string()
}
)
}

Expand Down
8 changes: 8 additions & 0 deletions core/src/response.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ pub struct Progresses {
pub result_progress: ProgressValues,
// make it optional for backward compatibility
pub total_scan: Option<ProgressValues>,
#[serde(default)]
pub spill_progress: SpillProgress,
}

impl Progresses {
Expand All @@ -53,6 +55,12 @@ pub struct ProgressValues {
pub bytes: usize,
}

#[derive(Debug, Clone, Deserialize, Serialize, Default)]
pub struct SpillProgress {
pub file_nums: usize,
pub bytes: usize,
}

#[derive(Serialize, Deserialize, Debug, Clone)]
pub struct SchemaField {
pub name: String,
Expand Down
13 changes: 3 additions & 10 deletions driver/src/conn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -199,13 +199,10 @@ pub trait Connection: Send + Sync {
Err(e) => (entry.to_string_lossy().to_string(), e.to_string()),
};
let ss = ServerStats {
total_rows: 0,
total_bytes: 0,
read_rows: 0,
read_bytes: 0,
write_rows: total_count,
write_bytes: total_size,
running_time_ms: 0.0,

..Default::default()
};
results.push(Ok(RowWithStats::Stats(ss)));
results.push(Ok(RowWithStats::Row(Row::from_vec(
Expand Down Expand Up @@ -255,13 +252,9 @@ pub trait Connection: Send + Sync {
Err(e) => (e.to_string(), 0),
};
let ss = ServerStats {
total_rows: 0,
total_bytes: 0,
read_rows: total_count,
read_bytes: total_size,
write_rows: 0,
write_bytes: 0,
running_time_ms: 0.0,
..Default::default()
};
results.push(Ok(RowWithStats::Stats(ss)));
results.push(Ok(RowWithStats::Row(Row::from_vec(
Expand Down
8 changes: 8 additions & 0 deletions sql/src/rows.rs
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@ pub struct ServerStats {

#[serde(default)]
pub running_time_ms: f64,

#[serde(default)]
pub spill_file_nums: usize,

#[serde(default)]
pub spill_bytes: usize,
}

impl ServerStats {
Expand All @@ -73,6 +79,8 @@ impl From<databend_client::QueryStats> for ServerStats {
read_bytes: stats.progresses.scan_progress.bytes,
write_rows: stats.progresses.write_progress.rows,
write_bytes: stats.progresses.write_progress.bytes,
spill_file_nums: stats.progresses.spill_progress.file_nums,
spill_bytes: stats.progresses.spill_progress.bytes,
running_time_ms: stats.running_time_ms,
};
if let Some(total) = stats.progresses.total_scan {
Expand Down
Loading