chore: fix vacuum drop table dry run bug (#12182)

* chore: fix vacuum drop table dry run bug

* chore: add test case

* add info log

src/query/service/src/interpreters/interpreter_vacuum_drop_tables.rs

@@ -27,6 +27,7 @@ use common_meta_app::schema::GcDroppedTableReq;
 use common_meta_app::schema::ListDroppedTableReq;
 use common_meta_app::schema::TableInfoFilter;
 use common_sql::plans::VacuumDropTablePlan;
+use tracing::info;
 use vacuum_handler::get_vacuum_handler;
 
 use crate::interpreters::Interpreter;
@@ -102,12 +103,15 @@ impl Interpreter for VacuumDropTablesInterpreter {
                 },
             )
             .await?;
-        // gc meta data
-        let req = GcDroppedTableReq {
-            tenant: self.ctx.get_tenant(),
-            drop_ids,
-        };
-        let _ = catalog.gc_drop_tables(req).await?;
+        // gc meta data only when not dry run
+        if self.plan.option.dry_run.is_none() {
+            info!("vacuum drop table drop_ids: {:?}", drop_ids);
+            let req = GcDroppedTableReq {
+                tenant: self.ctx.get_tenant(),
+                drop_ids,
+            };
+            let _ = catalog.gc_drop_tables(req).await?;
+        }
 
         match files_opt {
             None => return Ok(PipelineBuildResult::create()),

tests/suites/5_ee/01_vacuum/01_0002_ee_vacuum_drop_table.result

@@ -4,3 +4,5 @@
 4
 888
 1024
+1
+1

tests/suites/5_ee/01_vacuum/01_0002_ee_vacuum_drop_table.sh

@@ -7,6 +7,7 @@ CURDIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
 echo "drop database if exists test_vacuum_drop" | $MYSQL_CLIENT_CONNECT
 echo "drop database if exists test_vacuum_drop_2" | $MYSQL_CLIENT_CONNECT
 echo "drop database if exists test_vacuum_drop_3" | $MYSQL_CLIENT_CONNECT
+echo "drop database if exists test_vacuum_drop_4" | $MYSQL_CLIENT_CONNECT
 
 echo "CREATE DATABASE test_vacuum_drop" | $MYSQL_CLIENT_CONNECT
 echo "create table test_vacuum_drop.a(c int)" | $MYSQL_CLIENT_CONNECT
@@ -77,5 +78,15 @@ echo "drop table table_drop_external_location;" | $MYSQL_CLIENT_CONNECT
 
 echo "vacuum drop table retain 0 hours" | $MYSQL_CLIENT_CONNECT
 
+## dry run
+echo "CREATE DATABASE test_vacuum_drop_4" | $MYSQL_CLIENT_CONNECT
+echo "create table test_vacuum_drop_4.a(c int)" | $MYSQL_CLIENT_CONNECT
+echo "INSERT INTO test_vacuum_drop_4.a VALUES (1)" | $MYSQL_CLIENT_CONNECT
+echo "select * from test_vacuum_drop_4.a"  | $MYSQL_CLIENT_CONNECT
+echo "drop table test_vacuum_drop_4.a" | $MYSQL_CLIENT_CONNECT
+echo "vacuum drop table retain 0 hours dry run" | $MYSQL_CLIENT_CONNECT > /dev/null 
+echo "undrop table test_vacuum_drop_4.a" | $MYSQL_CLIENT_CONNECT
+echo "select * from test_vacuum_drop_4.a"  | $MYSQL_CLIENT_CONNECT
+
 ## Drop table
 echo "drop table if exists table_drop_external_location;" | $MYSQL_CLIENT_CONNECT