Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better displayText name when error #10253

Closed
BohuTANG opened this issue Feb 27, 2023 · 3 comments · Fixed by #10269
Closed

Better displayText name when error #10253

BohuTANG opened this issue Feb 27, 2023 · 3 comments · Fixed by #10269
Labels
good first issue Category: good first issue

Comments

@BohuTANG
Copy link
Member

Summary

ERROR 1105 (HY000): Code: 1065, displayText = Unsupported literal value: 58750003716598352816469.

It would be better to:

ERROR 1105 (HY000): Code: 1065, Text = Unsupported literal value: 58750003716598352816469.
@BohuTANG BohuTANG added the good first issue Category: good first issue label Feb 27, 2023
@rkmdCodes
Copy link
Contributor

hi I am interested in this goodfirstissue and i have located this file https://github.com/datafuselabs/databend/blob/5d902c06680f1fa6988371258231cc5cfa43ddd9/src/common/exception/src/exception_code.rs , can you please confirm ?

@BohuTANG
Copy link
Member Author

Hi @rkmdCodes

Thanks for taking it!

The code line should be:
https://github.com/datafuselabs/databend/blob/c0239ecf74dddfb1333c38d478468a55d4fb9fa4/src/common/exception/src/exception.rs#L168

I am afraid some tests need to be changed as well.

@haydenflinner
Copy link

As a related topic to this, 500 internal server error is always alarming to see when submitting a streaming upload. But it usually turns out that it's just a column name that's not in the table. 400 would be a better error code for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Category: good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants