Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated displayText to Text in error string #10269

Merged
merged 7 commits into from
Mar 28, 2023

Conversation

rkmdCodes
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Updated the error string as per required in raised issue , still working on locating the tests that need to be reconfigured.

Summary about this PR

Closes #10253

@vercel
Copy link

vercel bot commented Feb 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2023 at 2:22AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2023

This pull request's title is not fulfill the requirements. @rkmdCodes please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@BohuTANG BohuTANG changed the title updated displayText to Text in error string chore: updated displayText to Text in error string Feb 28, 2023
@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Feb 28, 2023
@BohuTANG
Copy link
Member

Hi @rkmdCodes

It would be helpful to run make lint in your locally, this will make the Dev Linux / check happy.
Before running it we can make setup to install the toolchain.

@rkmdCodes
Copy link
Contributor Author

hi @BohuTANG , I tried to build from source using make setup and make build release. After that I tried to run make lint but I got the cargo machete error I installed it and still got a few errors like command not found
image

@BohuTANG
Copy link
Member

@rkmdCodes

cargo machete is not affecting the cargo format, the style it's ok now.

The check CI failed due to the *.yml file, I have deleted it, it's not necessary to add it to this PR.

@BohuTANG BohuTANG self-requested a review February 28, 2023 14:51
@BohuTANG
Copy link
Member

Run cargo fmt --all on local will same as make lint :)

@BohuTANG
Copy link
Member

BohuTANG commented Mar 2, 2023

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Mar 2, 2023

update

❌ Base branch update has failed

refusing to allow a GitHub App to create or update workflow .github/workflows/benchmark.yml without workflows permission
err-code: 86CD3

@BohuTANG
Copy link
Member

BohuTANG commented Mar 2, 2023

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Mar 2, 2023

update

❌ Base branch update has failed

refusing to allow a GitHub App to create or update workflow .github/workflows/benchmark.yml without workflows permission
err-code: 55DAA

@BohuTANG
Copy link
Member

BohuTANG commented Mar 2, 2023

@rkmdCodes

Please rebase this PR with the main branch, the CI will be happy :)

@BohuTANG
Copy link
Member

Hello, I was wondering if there have been any recent updates regarding this PR? If not, I would like to offer my assistance in continuing the work.

@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Mar 15, 2023

update

❌ Base branch update has failed

refusing to allow a GitHub App to create or update workflow .github/workflows/benchmark.yml without workflows permission
err-code: 63B94

@rkmdCodes
Copy link
Contributor Author

hi @BohuTANG sir , thanks for offering assistance I was actually stuck at this point ,

@BohuTANG
Copy link
Member

git checkout main
git pull -ap
git reset --hard origin/main

git checkout <your branch>
git merge main

#10597

@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2023

update

❌ Base branch update has failed

refusing to allow a GitHub App to create or update workflow .github/workflows/benchmark.yml without workflows permission
err-code: 57581

@BohuTANG BohuTANG merged commit a3ac38f into databendlabs:main Mar 28, 2023
@BohuTANG
Copy link
Member

@rkmdCodes Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better displayText name when error
2 participants