Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

value_source_v2 shoud sync with value_source #6569

Closed
sundy-li opened this issue Jul 12, 2022 · 3 comments · Fixed by #6738
Closed

value_source_v2 shoud sync with value_source #6569

sundy-li opened this issue Jul 12, 2022 · 3 comments · Fixed by #6738
Assignees
@sundy-li

Comments

@sundy-li
Copy link
Member

value_source_v2 shoud sync with value_source? In this transitional stage, all changes in value_source may be lost in value_source_v2.

How can we guarantee it sync?

cc @sundy-li

Originally posted by @fkuner in #6565 (comment)
@sundy-li sundy-li self-assigned this Jul 12, 2022
@Xuanwo
Copy link
Member

Xuanwo commented Jul 13, 2022

Do we still use value_source? How about removing it entirely?

@fkuner
Copy link
Contributor

fkuner commented Jul 13, 2022

Do we still use value_source? How about removing it entirely?

We can't remove it now. Becaluse insert in old planner used it and value_source needs sqlparser to reparse when values have expression such as 1+1.

@Xuanwo
Copy link
Member

Xuanwo commented Jul 13, 2022

Cc @leiysky @andylokandy

Maybe we can remove it while we are removing the old planner?

@sundy-li sundy-li mentioned this issue Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sundy-li sundy-li

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(query): Fix values source skip_to_next_row sundy-li/databend
3 participants
@sundy-li @Xuanwo @fkuner