fix(query): fix values parser in skip_to_next_row #6565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
b41sh
reviewed
Jul 11, 2022
| @@ -184,8 +184,15 @@ pub fn skip_to_next_row<R: BufferRead>( | |||
| let c = buffer[it]; | |||
| reader.consume(it + 1); | |||
|
|
|||
| if it == 0 && escaped { | |||
There was a problem hiding this comment.
escaped just works for '.
There was a problem hiding this comment.
if the buffer is \(, this loop will continue, balance += 1 will not executed.
|
LGTM |
youngsofun
approved these changes
Jul 11, 2022
|
How can we guarantee it sync? cc @sundy-li |
Oh, I did not notice there is |
|
Yes, this is awful. Maybe we better remove v1 as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
Fix values parser in skip_to_next_row, If
'is escaped by\, it will continue to search a valid row.Fixes #issue