Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc: query result cache. #10014

Merged
merged 3 commits into from
Feb 14, 2023

Conversation

RinChanNOWWW
Copy link
Contributor

@RinChanNOWWW RinChanNOWWW commented Feb 13, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

RFC of query result cache.

Closes #10011

@vercel
Copy link

vercel bot commented Feb 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
databend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 14, 2023 at 1:28AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Feb 13, 2023

This pull request's title is not fulfill the requirements. @RinChanNOWWW please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@RinChanNOWWW RinChanNOWWW force-pushed the rfc-query-result-cache branch from 885b3d5 to aba9da7 Compare February 13, 2023 09:21
@RinChanNOWWW RinChanNOWWW changed the title RFC: query result cache. rfc: query result cache. Feb 13, 2023
@mergify mergify bot added the pr-rfc label Feb 13, 2023
@RinChanNOWWW RinChanNOWWW force-pushed the rfc-query-result-cache branch from aba9da7 to f80b49b Compare February 13, 2023 09:22
@RinChanNOWWW RinChanNOWWW force-pushed the rfc-query-result-cache branch 2 times, most recently from 9dd69c5 to e5856f8 Compare February 13, 2023 09:31
@RinChanNOWWW RinChanNOWWW force-pushed the rfc-query-result-cache branch from e5856f8 to fc5c1cf Compare February 13, 2023 09:40
@sundy-li sundy-li merged commit ed2be54 into databendlabs:main Feb 14, 2023
@RinChanNOWWW RinChanNOWWW deleted the rfc-query-result-cache branch February 14, 2023 01:36
@rschu1ze
Copy link

Hi! There seems to be a significant overlap in terms of design, integration and naming of this RFC and the recently introduced query cache in ClickHouse (which I am the author of). Perhaps allow me to post the original blog post and docs for reference, thanks.

@RinChanNOWWW
Copy link
Contributor Author

RinChanNOWWW commented Feb 28, 2023

Hi @rschu1ze, thanks for your comments and concerns.

For some namings and functionalities, we did refer other databases like ClickHouse and snowflake, we will add references in this RFC later.

For the detail design and implementation, Databend is totally different from ClickHouse. For example, ClickHouse use a hash table (has limit) to store cache information and tolerate inconsistent. However, Databend use its meta service (doesn't have limit) to store cache information and doesn't allow inconsistent by default.

You can find the implementation of the first version of query result cache in #10010, and we didn't refer any codes of ClickHouse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: query result cache
5 participants