Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): query result cache #10042

Merged
merged 9 commits into from
Feb 21, 2023
Merged

feat(query): query result cache #10042

merged 9 commits into from
Feb 21, 2023

Conversation

RinChanNOWWW
Copy link
Contributor

@RinChanNOWWW RinChanNOWWW commented Feb 14, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Implement the basic query result cache.

More details about the design can be found in the RFC.

Pipeline:

             ┌─────────┐ 1  ┌─────────┐ 1
             │         ├───►│         ├───►Dummy───►Downstream
Upstream────►│Duplicate│ 2  │         │ 3
             │         ├───►│         ├───►Dummy───►Downstream
             └─────────┘    │         │
                            │ Shuffle │
             ┌─────────┐ 3  │         │ 2  ┌─────────┐
             │         ├───►│         ├───►│  Write  │
Upstream────►│Duplicate│ 4  │         │ 4  │ Result  │
             │         ├───►│         ├───►│  Cache  │
             └─────────┘    └─────────┘    └─────────┘

@vercel
Copy link

vercel bot commented Feb 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Feb 21, 2023 at 6:55AM (UTC)

@RinChanNOWWW RinChanNOWWW mentioned this pull request Feb 14, 2023
Closed
11 tasks
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Feb 14, 2023
@RinChanNOWWW RinChanNOWWW force-pushed the query-result-cache branch 4 times, most recently from 78581da to 1ccae9e Compare February 17, 2023 14:55
@RinChanNOWWW
Copy link
Contributor Author

Almost ready for review.

@RinChanNOWWW
Copy link
Contributor Author

Rely on #10127.

@RinChanNOWWW RinChanNOWWW force-pushed the query-result-cache branch 5 times, most recently from 6f0d635 to 0e579d6 Compare February 20, 2023 09:55
@RinChanNOWWW RinChanNOWWW marked this pull request as ready for review February 21, 2023 01:36
@RinChanNOWWW RinChanNOWWW force-pushed the query-result-cache branch 2 times, most recently from 937fd45 to 64b7b5c Compare February 21, 2023 04:55
@RinChanNOWWW
Implemention cache read.
7209a71
@RinChanNOWWW
Fix.
6795ce0
@RinChanNOWWW
Complete the pipeline.
5399e9b
@RinChanNOWWW
Fix pipeline.
c32a08a 
Fix default value.

Fix unit test and enable `tolerate_inconsistent` setting.

Disable query result cacahe for multi tables.
@RinChanNOWWW
Fix ttl.
e26bb1d
@RinChanNOWWW
Add sql logic tests.
10e3a1d
@RinChanNOWWW
Do not raise error if read cache failed.
bb8cc57
@mergify mergify bot merged commit 6a17159 into databendlabs:main Feb 21, 2023
@RinChanNOWWW RinChanNOWWW deleted the query-result-cache branch February 21, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG left review comments

@sundy-li sundy-li sundy-li approved these changes

@ariesdevil ariesdevil ariesdevil approved these changes

@zhang2014 zhang2014 Awaiting requested review from zhang2014

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RinChanNOWWW @BohuTANG @sundy-li @ariesdevil @zhang2014