Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implementation of Default for config::CacheConfig should use values from inner::CacheConfig #10089

Merged

Conversation

dantengsky
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

implementation of Default for config::CacheConfig should use values from inner::CacheConfig

after fix:

CACHE_ENABLE_TABLE_META_CACHE=true ./target/debug/databend-query --meta-embedded-dir .databend/meta

default values of cache configs are as expected

mysql> select * from system.configs where "group" = 'cache';
+-------+----------------------------------------+--------------------+-------------+
| group | name                                   | value              | description |
+-------+----------------------------------------+--------------------+-------------+
| cache | enable_table_meta_cache                | true               |             |
| cache | table_meta_snapshot_count              | 256                |             |
| cache | table_meta_segment_count               | 10240              |             |
| cache | table_meta_statistic_count             | 256                |             |
| cache | enable_table_bloom_index_cache         | true               |             |
| cache | table_bloom_index_meta_count           | 3000               |             |
| cache | table_bloom_index_filter_count         | 1048576            |             |
| cache | data_cache_storage                     | none               |             |
| cache | table_data_cache_population_queue_size | 65536              |             |
| cache | disk.max_bytes                         | 21474836480        |             |
| cache | disk.path                              | ./.databend/_cache |             |
| cache | table_data_deserialized_data_bytes     | 0                  |             |
+-------+----------------------------------------+--------------------+-------------+

Closes #10088

@vercel
Copy link

vercel bot commented Feb 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Feb 16, 2023 at 2:38PM (UTC)

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Feb 16, 2023
@dantengsky dantengsky marked this pull request as ready for review February 16, 2023 14:57
@dantengsky dantengsky merged commit 1f1c939 into databendlabs:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: incorrect default cache config values used if one of the cache config entries is set by using env var
2 participants