Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: changes alter functions example to make the function body reflect the name and match other doc examples #10092

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

cameronbraid
Copy link
Contributor

@cameronbraid cameronbraid commented Feb 16, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

changes docs example to make the function body reflect the name and match other doc examples

@vercel
Copy link

vercel bot commented Feb 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
databend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 16, 2023 at 10:27PM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2023

This pull request's title is not fulfill the requirements. @cameronbraid please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@cameronbraid cameronbraid changed the title the dissonance disturbed me when reading ! docs: changes alter functions example to make the function body reflect the name and match other doc examples Feb 16, 2023
@mergify mergify bot added the pr-doc this PR needs/changes the documents or websites label Feb 16, 2023
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@BohuTANG BohuTANG merged commit b606cb4 into databendlabs:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-doc this PR needs/changes the documents or websites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants