refactor: remove dependency of common-exceptionn from common-meta-types #10114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crate `common-meta-types` provides just query-meta communication protocol types. It does not care about the user interface level `ErrorCode` or error types used internally in databend-query. Conversion from `Meta*Error` to `ErrorCode` is moved to crate `common-exception`. All `Meta*Error` for query is an unhandlable internal error.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
drmingdrmer
changed the title
mergify
bot
added
the
pr-refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Refactor: remove dependency of common-exceptionn from common-meta-types
Crate
common-meta-typesprovides just query-meta communication protocoltypes. It does not care about the user interface level
ErrorCodeorerror types used internally in databend-query.
Conversion from
Meta*ErrortoErrorCodeis moved tocrate
common-exception.All
Meta*Errorfor query is an unhandlable internal error.Changelog
Related Issues