Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): make native format support compaction/mutation #10135

Merged
merged 12 commits into from
Feb 21, 2023
Merged

chore(storage): make native format support compaction/mutation #10135

merged 12 commits into from
Feb 21, 2023

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Feb 20, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

  1. Add table engine docs, cover fuse engine, and memory engine.
  2. Make native format support compaction and mutation
  3. Improve heap sort via https://togithub.com/rust-lang/rust/pull/107894
  4. Add default_storage_format and default_compression config, which defaults to 'auto'

Closes #issue

@vercel
Copy link

vercel bot commented Feb 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
databend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 8:24AM (UTC)

@sundy-li sundy-li requested a review from dantengsky February 20, 2023 09:17
@sundy-li sundy-li changed the title doc(storage): add table engine docs docs(storage): add table engine docs Feb 20, 2023
@mergify mergify bot added the pr-doc this PR needs/changes the documents or websites label Feb 20, 2023
@sundy-li sundy-li marked this pull request as draft February 20, 2023 09:51
@sundy-li sundy-li changed the title docs(storage): add table engine docs chore(storage): make native format support compaction/mutation Feb 20, 2023
@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Feb 20, 2023
@databendlabs databendlabs deleted a comment from mergify bot Feb 21, 2023
@sundy-li sundy-li requested a review from zhyass February 21, 2023 01:23
@sundy-li sundy-li marked this pull request as ready for review February 21, 2023 05:14
@sundy-li sundy-li added the ci-benchmark Benchmark: run all test label Feb 21, 2023
@github-actions
Copy link
Contributor

platform
Benchmark Results: https://repo.databend.rs/benchmark/clickbench/pr/10135/4230322710.html

zhyass
zhyass approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@zhyass zhyass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 476b3ed into databendlabs:main Feb 21, 2023
@github-actions
Copy link
Contributor

platform
Benchmark Results: https://repo.databend.rs/benchmark/clickbench/pr/10135/4230616808.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhyass zhyass zhyass approved these changes

@dantengsky dantengsky Awaiting requested review from dantengsky

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-chore this PR only has small changes that no need to record, like coding styles. pr-doc this PR needs/changes the documents or websites
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sundy-li @zhyass