Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adopt OpenDAL's batch delete support #10150

Merged
merged 4 commits into from
Feb 22, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Feb 21, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Adopt OpenDAL's batch delete support for delete performance.

Closes #10148

Signed-off-by: Xuanwo <github@xuanwo.io>
@vercel
Copy link

vercel bot commented Feb 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Feb 22, 2023 at 2:59AM (UTC)

@Xuanwo
Copy link
Member Author

Xuanwo commented Feb 21, 2023

cc @BohuTANG, can you help take a bench on it?

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Feb 21, 2023
@Xuanwo Xuanwo marked this pull request as draft February 21, 2023 13:33
@Xuanwo
Copy link
Member Author

Xuanwo commented Feb 21, 2023

Test failed, I am invetisgating.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo marked this pull request as ready for review February 21, 2023 15:37
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Feb 21, 2023

Also related to apache/opendal#1396

@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Feb 22, 2023

update

✅ Branch has been successfully updated

@BohuTANG BohuTANG self-requested a review February 22, 2023 04:20
@BohuTANG BohuTANG merged commit 7a2878a into databendlabs:main Feb 22, 2023
@Xuanwo Xuanwo deleted the bump-opendal branch February 22, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: change batch remove to opendal batch
2 participants