Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move compress related code into databend #10177

Merged
merged 13 commits into from
Feb 23, 2023
Merged

refactor: Move compress related code into databend #10177

merged 13 commits into from
Feb 23, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Feb 23, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

OpenDAL will not maintain those logic.

@Xuanwo
refactor: Move compress related code into databend
85d2b40 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
format toml
cf8ee85 
Signed-off-by: Xuanwo <github@xuanwo.io>
@vercel
Copy link

vercel bot commented Feb 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Visit Preview Feb 23, 2023 at 1:41PM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Feb 23, 2023
@Xuanwo
Fix typo
41add05 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
FIx test
d795758 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
ignore compress test
4ab202f 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Address comment
776324f 
Signed-off-by: Xuanwo <github@xuanwo.io>
@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Feb 23, 2023

update

✅ Branch has been successfully updated

@Xuanwo
Remove doc test
6fa7a87 
Signed-off-by: Xuanwo <github@xuanwo.io>
@BohuTANG
Copy link
Member 

cargo-machete found the following unused dependencies in /workspace:
common-storage -- /workspace/src/common/storage/Cargo.toml:
	async-compression
Done!

@BohuTANG
Copy link
Member

The Dev Linux / check CI failure was solved by #10190

@Xuanwo
Make cargo-machete happy
086aa52 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Remove rust doc test
8414e26 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Merge remote-tracking branch 'origin/main' into move-compress
a4bc6e0 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Merge remote-tracking branch 'xuanwo/move-compress' into move-compress
b83644c 
Signed-off-by: Xuanwo <github@xuanwo.io>
@mergify mergify bot merged commit 6ffbc4c into databendlabs:main Feb 23, 2023
@Xuanwo Xuanwo deleted the move-compress branch February 23, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG left review comments

@sundy-li sundy-li sundy-li approved these changes

@youngsofun youngsofun youngsofun approved these changes

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xuanwo @BohuTANG @sundy-li @youngsofun