Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new feature enable-histogram-metrics #10449

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Mar 8, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

introduce a new cargo feature enable-histogram-metrics, which can enable the histogram metrics

  • by default, it is disabled, metrics of histogram will be no-op
  • if enabled, metrics of histogram will be "generated"
    e.g. cargo b --features enable-histogram-metrics

the "reason" of disabling histogram by default : metrics-rs/metrics#245

Closes #10428

@vercel
Copy link

vercel bot commented Mar 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Mar 8, 2023 at 2:46PM (UTC)

@dantengsky dantengsky changed the title feature: new feature enable-histogram-metrics feat: new feature enable-histogram-metrics Mar 8, 2023
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Mar 8, 2023
@dantengsky dantengsky marked this pull request as ready for review March 9, 2023 01:29
@dantengsky dantengsky requested a review from BohuTANG March 9, 2023 01:29
@BohuTANG BohuTANG merged commit 70d400a into databendlabs:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: add cargo feature to enable histogram metrics
2 participants