Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): Map data type support bloom filter #10457

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Mar 9, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Map data type support bloom filter

Part of #10062

From the test data example, we can see that the bloom filter is effective in reducing the query time if the value of the query does not exist.

MySQL root@127.0.0.1:default> select count(*) from test;
+----------+
| count(*) |
+----------+
| 100000   |
+----------+
1 row in set
Time: 0.153s
MySQL root@127.0.0.1:default> select * from test where log['ip'] = '205.91.162.148';
+----+----------------------------------------+
| id | log                                    |
+----+----------------------------------------+
| 1  | {'ip':'205.91.162.148','url':'test-1'} |
+----+----------------------------------------+
1 row in set
Time: 1.733s
MySQL root@127.0.0.1:default> select * from test where log['ip'] = '205.91.162.141';
+----+-----+
| id | log |
+----+-----+
+----+-----+
0 rows in set
Time: 0.129s

@vercel
Copy link

vercel bot commented Mar 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Mar 9, 2023 at 9:26AM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Mar 9, 2023
@b41sh b41sh marked this pull request as ready for review March 9, 2023 09:27
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BohuTANG BohuTANG merged commit c3bdc00 into databendlabs:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants