-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[store] feature: sled backed raft state #1056
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
databend-bot
added
pr-feature
this PR introduces a new feature to the codebase
pr-improvement
labels
Jul 15, 2021
Thanks for the contribution! Please review the labels and make any necessary changes. |
ariesdevil
reviewed
Jul 15, 2021
- When starting a MetaNode(and a DFS that depends on a MetaNode), assign a on-disk dir for it to store persisted raft state, including: `node_id`, `current_term`, `voted_for`. - Add: RaftState, which is a disk backed store of raft state. - Change: MetaStore::new() now accepts a complete Config instead of a single listening addr. - Test: add new_test_context() to create a temp env for testing MetaNode or DFS, which includes a temp meta store dir, unique port for meta service etc. - Test: all tests that invovles a MetaStore assign a temp dir for meta storage.
dantengsky
approved these changes
Jul 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI Passed |
This was referenced Jul 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/
Summary
[store] feature: sled backed raft state
When starting a MetaNode(and a DFS that depends on a MetaNode),
assign a on-disk dir for it to store persisted raft state, including:
node_id
,current_term
,voted_for
.Add: RaftState, which is a disk backed store of raft state.
Change: MetaStore::new() now accepts a complete Config instead of a
single listening addr.
Test: add new_test_context() to create a temp env for testing MetaNode
or DFS, which includes a temp meta store dir, unique port for meta
service etc.
Test: all tests that involves a MetaStore assign a temp dir for meta
storage.
[store] refactor: move netowk to network.rs
[store] refactor: rename MetaStore field names.
Changelog
New Feature
Improvement
Related Issues
#271
Fix: #1051