Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): make flush returns empty builder #10715

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Mar 22, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Test #10483 is leaked or not.

image

If the processor is leaked (unsafe codes in pipeline processor), object BlockBuilder will be memory leaked thus the builder will be memory leaked.

Closes #issue

@sundy-li sundy-li requested a review from andylokandy March 22, 2023 16:55
@vercel
Copy link

vercel bot commented Mar 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Mar 22, 2023 at 11:37PM (UTC)

@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 22, 2023
@sundy-li sundy-li requested a review from zhang2014 March 22, 2023 17:01
Co-authored-by: Andy Lok <andylokandy@hotmail.com>
@BohuTANG BohuTANG merged commit ae0effb into databendlabs:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants