Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): zero copy conversion with arrow-rs #10818

Merged
merged 7 commits into from
Mar 29, 2023

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Mar 29, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

  1. zero copy conversion with arrow-rs
  2. support metadata to arrow's schema
  3. fix string type mapping to arrow's LargeBinary

JSON response works, but it's displayed as binary (need a better display on client side)

❯ arrow_cli -h arch -u sundy -p abc --port 8900
Welcome to Arrow CLI.
Connecting to http://arch:8900/ as user sundy.

arch :) select try_parse_json( '{}') a;

select try_parse_json( '{}') a;

+----------+
| a        |
+----------+
| 40000000 |
+----------+

1 rows in set (0.030 sec)

Closes #issue

@vercel
Copy link

vercel bot commented Mar 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Visit Preview Mar 29, 2023 at 11:54AM (UTC)

@sundy-li sundy-li requested a review from youngsofun March 29, 2023 03:07
@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 29, 2023
@sundy-li sundy-li marked this pull request as draft March 29, 2023 04:27
@sundy-li sundy-li marked this pull request as ready for review March 29, 2023 04:37
@sundy-li sundy-li requested a review from TCeason March 29, 2023 04:37
@BohuTANG
Copy link
Member

Dev Linux / test_unit need fixed.

@youngsofun youngsofun merged commit 8b6c32b into databendlabs:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants