Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): read snapshot with wrong version #11099

Merged
merged 1 commit into from
Apr 17, 2023
Merged

fix(storage): read snapshot with wrong version #11099

merged 1 commit into from
Apr 17, 2023

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Apr 17, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

fix optimize purge panic, when a table contains v2 and v3 snapshots.

mysql> optimize table t purge;
ERROR 1105 (HY000): Code: 1001, Text = try join all futures failure, task 322 panicked.

Closes #11098

@vercel
Copy link

vercel bot commented Apr 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Apr 17, 2023 3:09pm

@zhyass zhyass requested a review from dantengsky April 17, 2023 15:08
@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Apr 17, 2023
@zhyass zhyass requested a review from BohuTANG April 17, 2023 15:08
@zhyass zhyass mentioned this pull request Apr 17, 2023
Merged
jun0315
jun0315 approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@jun0315 jun0315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dantengsky dantengsky merged commit 706f420 into databendlabs:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jun0315 jun0315 jun0315 approved these changes

@dantengsky dantengsky dantengsky approved these changes

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: read snapshot with wrong version
3 participants
@zhyass @dantengsky @jun0315