Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refine the default column value error #11169

Merged
merged 1 commit into from
Apr 21, 2023
Merged

chore: refine the default column value error #11169

merged 1 commit into from
Apr 21, 2023

Conversation

BohuTANG
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • better error msg when the default column value is not constant expression
  • better the doc for create table and alter table add/drop column

Closes #issue

@vercel
Copy link

vercel bot commented Apr 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
databend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2023 11:11am

@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Apr 21, 2023
@BohuTANG BohuTANG marked this pull request as ready for review April 21, 2023 11:27
@BohuTANG BohuTANG requested a review from sundy-li April 21, 2023 11:27
@BohuTANG
Copy link
Member Author

Only change a error message and improve some documents related to the create table, let's merge.

@BohuTANG BohuTANG merged commit 4814397 into databendlabs:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BohuTANG