fix: the map build_segment_id_map returns should contain format ver
#11212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dantengsky
changed the title
build_segment_id_map returns should contain format verbuild_segment_id_map returns should contain format ver
dantengsky
force-pushed
the
fix-build_segmement-id-map
branch
from
cce7c5f to
53f3cc7
Compare
dantengsky
changed the title
build_segment_id_map returns should contain format verbuild_segment_id_map returns should contain format ver
dantengsky
changed the title
build_segment_id_map returns should contain format verbuild_segment_id_map returns should contain format ver
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
build_segment_id_mapreturns should contain format veri.e. instead of
HashMap<String, usize>, we should useHashMap<Location, usize>TransformRowsFetchershould use the format version of segment to load the segment, not the version of the snapshotCloses #issue