Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vacuum impl #11320

Merged
merged 16 commits into from
May 9, 2023
Merged

feat: add vacuum impl #11320

merged 16 commits into from
May 9, 2023

Conversation

lichuang
Copy link
Contributor

@lichuang lichuang commented May 5, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

feat: add vacuum impl

Closes #issue

@lichuang lichuang requested review from dantengsky, ZhiHanZ and zhyass May 5, 2023 09:33
@vercel
Copy link

vercel bot commented May 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Visit Preview May 9, 2023 7:12am

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label May 5, 2023
@lichuang lichuang marked this pull request as ready for review May 8, 2023 04:12
@dantengsky dantengsky requested a review from BohuTANG May 8, 2023 04:12
Copy link
Member

@flaneur2020 flaneur2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interface manager design needs some further discussion.

@ZhiHanZ
Copy link
Collaborator

ZhiHanZ commented May 8, 2023

Can we add some integration tests to vacuum command?

@flaneur2020 flaneur2020 self-requested a review May 8, 2023 09:01
Copy link
Member

@zhyass zhyass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 6c8784d into databendlabs:main May 9, 2023
Dousir9 pushed a commit to Dousir9/databend that referenced this pull request May 10, 2023
* feat: add vacuum impl

* feat: add vacuum impl

* fix: add InterfaceManager

* fix: add vacuum impl

* fix: add oss license manager

* fix: add oss license manager

* fix: rename InterfaceManager to VacuumHandler; add stateful test

* fix test fail

* refactor ee feature dirs

* rename file with ee prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants