Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optimize broadcast join #11365

Merged
merged 4 commits into from
May 10, 2023
Merged

feat: optimize broadcast join #11365

merged 4 commits into from
May 10, 2023

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented May 8, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • Remove useless partition exchange in broadcast join
  • Add threshold for broadcast join
image

Closes #issue

@xudong963 xudong963 marked this pull request as draft May 8, 2023 15:31
@vercel
Copy link

vercel bot commented May 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
databend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 4:12pm

@xudong963 xudong963 added the ci-benchmark Benchmark: run all test label May 8, 2023
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label May 8, 2023
@xudong963 xudong963 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels May 8, 2023
@xudong963 xudong963 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels May 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

local cloud cloud

ClickBench Report

@xudong963 xudong963 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels May 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

local cloud cloud

ClickBench Report

@xudong963 xudong963 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels May 9, 2023
@xudong963 xudong963 removed the ci-benchmark Benchmark: run all test label May 9, 2023
@xudong963 xudong963 added the ci-benchmark Benchmark: run all test label May 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

local cloud cloud

ClickBench Report

@xudong963 xudong963 marked this pull request as ready for review May 9, 2023 14:07
@xudong963 xudong963 requested review from leiysky and sundy-li May 9, 2023 14:07
@sundy-li
Copy link
Member

is it slower now?

@xudong963
Copy link
Member Author

is it slower now?

Nope

@xudong963 xudong963 merged commit 4e66b31 into databendlabs:main May 10, 2023
@xudong963 xudong963 deleted the broadcast_join branch May 10, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@leiysky leiysky Awaiting requested review from leiysky

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xudong963 @sundy-li