refactor(schema-api): remove unused upsert_table_copied_file_info from trait SchemaApi and trait Database #11379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m trait SchemaApi and trait Database Updating copied files is actually done with `SchemaApi::update_table_meta()`
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
drmingdrmer
changed the title
|
This pull request's title is not fulfill the requirements. @drmingdrmer please update it 🙏. Valid format: Valid types:
|
mergify
bot
added
the
pr-refactor
|
@mergify update |
❌ Base branch update has failedexpected head sha didn’t match current head ref. |
Dousir9
pushed a commit
to Dousir9/databend
that referenced
this pull request
May 10, 2023
…m trait SchemaApi and trait Database (databendlabs#11379) * chore(schema-api): refactor * refactor(schema-api): remove unused upsert_table_copied_file_info from trait SchemaApi and trait Database Updating copied files is actually done with `SchemaApi::update_table_meta()` * fixup(schema-api-test): fix test according to latest change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
refactor(schema-api): remove unused upsert_table_copied_file_info from trait SchemaApi and trait Database
Updating copied files is actually done with
SchemaApi::update_table_meta()