-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): improve cardinality estimate #11394
Merged
BohuTANG
merged 7 commits into
databendlabs:main
from
Dousir9:improve_cardinality_estimate
May 19, 2023
Merged
feat(query): improve cardinality estimate #11394
BohuTANG
merged 7 commits into
databendlabs:main
from
Dousir9:improve_cardinality_estimate
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mergify
bot
added
the
pr-feature
this PR introduces a new feature to the codebase
label
May 10, 2023
sundy-li
approved these changes
May 18, 2023
Dousir9
added
ci-benchmark
Benchmark: run all test
and removed
ci-benchmark
Benchmark: run all test
labels
May 18, 2023
Great. But there is a tpcds test broken:
|
Dousir9
force-pushed
the
improve_cardinality_estimate
branch
from
May 19, 2023 01:34
c88b9b6
to
e698a4a
Compare
leiysky
approved these changes
May 19, 2023
andylokandy
pushed a commit
to andylokandy/databend
that referenced
this pull request
Nov 27, 2023
* improve cardinality estimate * update other statistic by selectivity * dphyp * fix dphyp subquery * remove tpcds q64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
1. Adjust ndv
max - min + 1 < ndv
, we will adjustndv
tomax - min + 1
.2. Improve histogram bucket
3. Update statistic by selectivity
4. Return the updated column_stats upwards
5. Improve join cardinality computation
6. enable
enable_dphyp
by defaultFor TPC-H Q2, Q3, Q5, Q8, Q10, Q18, Q21 after this PR, we will get better join order.
Closes #issue