Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(meta-ctl): refine stderr output for metactl #11404

Merged
merged 1 commit into from
May 11, 2023

Conversation

drmingdrmer
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

chore(meta-ctl): refine stderr output for metactl

Changelog

Related Issues

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) May 11, 2023 0:02am

@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label May 11, 2023
@drmingdrmer drmingdrmer marked this pull request as ready for review May 11, 2023 08:09
@drmingdrmer drmingdrmer requested a review from lichuang May 11, 2023 08:09
@BohuTANG
Copy link
Member

error: empty string literal in `eprintln!`
   --> src/binaries/metactl/main.rs:234:5
    |
234 |     eprintln!("");
    |     ^^^^^^^^^^--^
    |               |
    |               help: remove the empty string
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
    = note: `-D clippy::println-empty-string` implied by `-D warnings`

error: empty string literal in `eprintln!`
   --> src/binaries/metactl/main.rs:256:9
    |
256 |         eprintln!("");
    |         ^^^^^^^^^^--^
    |                   |
    |                   help: remove the empty string
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string

error: empty string literal in `eprintln!`
   --> src/binaries/metactl/main.rs:262:9
    |
262 |         eprintln!("");
    |         ^^^^^^^^^^--^
    |                   |
    |                   help: remove the empty string
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string

@BohuTANG BohuTANG merged commit 222419f into databendlabs:main May 11, 2023
@drmingdrmer drmingdrmer deleted the 61-metactl-output branch May 11, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants