feat(query): add func date_format and str_to_date and str_to_timestamp #11442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mergify
bot
added
the
pr-feature
youngsofun
approved these changes
May 14, 2023
This comment was marked as outdated.
This comment was marked as outdated.
BohuTANG
reviewed
May 14, 2023
|
These functions requires additional documentation. Thanks! cc @soyeric128 We already have an powerful date format function in place. cc @wubx |
sundy-li
reviewed
May 14, 2023
| output.push_null(); | ||
| } else { | ||
| match (std::str::from_utf8(date), std::str::from_utf8(format)) { | ||
| (Ok(date), Ok(format)) => { |
There was a problem hiding this comment.
Refer to MySQL behavior here. Return null directly if there is any invalid
There was a problem hiding this comment.
I think we should not follow MySQL's behavior, we should throw if any error happens.
There was a problem hiding this comment.
I think we should not follow MySQL's behavior, we should throw if any error happens.
Modify in this pr: #11455
andylokandy
pushed a commit
to andylokandy/databend
that referenced
this pull request
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
support function:
date_format(Timestamp, String) :: String NULL
date_format(Timestamp NULL, String NULL) :: String NULL
str_to_date(String, String) :: Date NULL
str_to_date(String NULL, String NULL) :: Date NULL
str_to_timestamp(String, String) :: Timestamp NULL
str_to_timestamp(String NULL, String NULL) :: Timestamp NULL
Note
Closes #11125