Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bitmap count aggregate function #11542

Merged
merged 5 commits into from
May 22, 2023
Merged

Conversation

gitccl
Copy link
Contributor

@gitccl gitccl commented May 22, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Add 3 bitmap count aggregate function: bitmap_and_count, bitmap_or_count, bitmap_xor_count.

Part of #11219

@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Visit Preview May 22, 2023 2:06pm

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label May 22, 2023
@sundy-li sundy-li requested a review from b41sh May 22, 2023 10:41
@b41sh
Copy link
Member

b41sh commented May 22, 2023

@gitccl Thanks for your contribution, it's basically ok, please add some unit tests for these functions.

@gitccl
Copy link
Contributor Author

gitccl commented May 22, 2023

@gitccl Thanks for your contribution, it's basically ok, please add some unit tests for these functions.

Done

@mergify mergify bot merged commit d3a40d9 into databendlabs:main May 22, 2023
@gitccl gitccl deleted the bitmap_agg branch May 22, 2023 15:31
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
* feat: add bitmap count aggregate function

* tests: add bitmap count aggregate unit test

* fix: fix check

---------

Co-authored-by: sundyli <543950155@qq.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants