Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch table meta encoding scheme to msgpack #11592

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make v4::Segment::to_bytes_with_encoding private
dantengsky committed Jun 1, 2023

Verified

This commit was signed with the committer’s verified signature.
jasnell James M Snell
commit 024e6c0e7ec83413e69132affd6687c1878b685d
1 change: 1 addition & 0 deletions src/query/storages/common/table-meta/benches/bench.rs
Original file line number Diff line number Diff line change
@@ -77,6 +77,7 @@ fn bench_encode(c: &mut Criterion) {
})
});

#[cfg(comment_out)]
grp.bench_function("bincode-segment-serialization", |b| {
b.iter(|| {
let _ = segment_info
Original file line number Diff line number Diff line change
@@ -144,7 +144,7 @@ impl SegmentInfo {
self.to_bytes_with_encoding(MetaEncoding::MessagePack)
}

pub fn to_bytes_with_encoding(&self, encoding: MetaEncoding) -> Result<Vec<u8>> {
fn to_bytes_with_encoding(&self, encoding: MetaEncoding) -> Result<Vec<u8>> {
let compression = MetaCompression::default();

let blocks = encode(&encoding, &self.blocks)?;