Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Copy into support optimize hint #11614

Merged
merged 7 commits into from
Jun 1, 2023
Merged

feat: Copy into support optimize hint #11614

merged 7 commits into from
Jun 1, 2023

Conversation

jun0315
Copy link
Contributor

@jun0315 jun0315 commented May 29, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Like this :

copy /*+ SET_VAR(parquet_read_whole_file_threshold=4096) */ into ...

Closes ##11253
Related #11610

@vercel
Copy link

vercel bot commented May 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Visit Preview Jun 1, 2023 3:12am

@jun0315 jun0315 changed the title Feature: Copy into support optimize hint feat: Copy into support optimize hint May 29, 2023
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label May 29, 2023
@jun0315 jun0315 requested a review from TCeason May 30, 2023 16:39
@jun0315 jun0315 marked this pull request as ready for review May 30, 2023 16:39
@jun0315 jun0315 requested a review from youngsofun May 30, 2023 16:39
@youngsofun
Copy link
Member

why remove the tests?

Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can test it in #11610

tests/suites/0_stateless/05_hints/05_0001_set_var.sh Outdated Show resolved Hide resolved
tests/suites/0_stateless/05_hints/05_0001_set_var.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can test it in #11610

@TCeason TCeason merged commit 68a8271 into databendlabs:main Jun 1, 2023
@jun0315 jun0315 deleted the set_var branch June 1, 2023 08:28
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
* fix: init

* fix: ut

* fix: ut

* test: add copy into

* test: rm set_var test

* test: add copy test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants