Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): Support computed columns #11689

Merged
merged 17 commits into from
Jun 12, 2023

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Jun 7, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Support computed columns

  • Create a table with stored and virtual computed columns
  • Insert/Update/Delete/Copy values to a table with computed columns
  • Select values from a table with computed columns

Closes #11390

@vercel
Copy link

vercel bot commented Jun 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2023 1:40am

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jun 7, 2023
@dantengsky
Copy link
Member

dantengsky commented Jun 8, 2023

@b41sh

stateful test failed:

https://github.com/datafuselabs/databend/actions/runs/5194994828/jobs/9367388532?pr=11689#step:4:532

00_0009_copy_csv_with_computed_column:                                  [ FAIL ] - return code 126
, result:

/bin/sh: 1: /runner/_work/databend/databend/tests/suites/1_stateful/00_copy/00_0009_copy_csv_with_computed_column.sh: Permission denied

maybe we need to chmod +x 00_0009_copy_csv_with_computed_column.sh ?

@b41sh
Copy link
Member Author

b41sh commented Jun 8, 2023

@b41sh

stateful test failed:

https://github.com/datafuselabs/databend/actions/runs/5194994828/jobs/9367388532?pr=11689#step:4:532

00_0009_copy_csv_with_computed_column:                                  [ FAIL ] - return code 126
, result:

/bin/sh: 1: /runner/_work/databend/databend/tests/suites/1_stateful/00_copy/00_0009_copy_csv_with_computed_column.sh: Permission denied

maybe we need to chmod +x 00_0009_copy_csv_with_computed_column.sh ?
yes, I will fix it.

@b41sh b41sh marked this pull request as ready for review June 10, 2023 13:21
@b41sh b41sh requested a review from drmingdrmer as a code owner June 10, 2023 13:21
@b41sh b41sh requested review from sundy-li and dantengsky June 10, 2023 13:21
@BohuTANG BohuTANG merged commit 2eeb184 into databendlabs:main Jun 12, 2023
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
* feat(query): Support computed columns

* fix

* fix

* fix insert

* update

* fix

* fix

* fix

* add tests

* fix

* fix

* fix

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: sundyli <543950155@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support computed columns
5 participants