Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: select $<column_position> from CSV #11739

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Jun 13, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. all column is string type.
  2. can only use $N, do not support *
  3. allow CSV rows to have diff num of fields. currently support at most 1000 fields or the max of $N. (we can make 1000 a config if we really need it later)
  4. if N is large then num fields of a row, get "".

cc @wubx

Closes #issue

@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
databend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 7:46pm

@youngsofun youngsofun marked this pull request as draft June 13, 2023 08:34
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jun 13, 2023
@youngsofun youngsofun marked this pull request as ready for review June 13, 2023 08:37
@youngsofun
Copy link
Member Author

flaky tests

https://github.com/datafuselabs/databend/actions/runs/5253743422/jobs/9491694617?pr=11739

query III
select (select count(*) from t1 as x where x.b<t1.b) as col1,
       case when c>(select avg(c) from t1) then a*2 else b*10 end as col2,
       c-d as col3
from t1
order by col2,col3,col1
    8 1430 1
-   9 1450 -1
+   8 1450 -1
    10 1510 -4

@youngsofun
Copy link
Member Author

youngsofun commented Jun 14, 2023

  Cannot retrieve metalink for repository: epel/x86_64. Please verify its path and try again
  Error: The process '/usr/bin/docker' failed with exit code 1
      at ExecState._setResult (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1702:25)
      at ExecState.CheckComplete (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1685:18)
      at ChildProcess.<anonymous> (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1579:27)
      at ChildProcess.emit (node:events:527:28)
      at maybeClose (node:internal/child_process:1092:16)
      at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)
  Error: The process '/usr/bin/docker' failed with exit code 1

cc @BohuTANG @everpcpc @sundy-li

@BohuTANG BohuTANG merged commit cb63cf9 into databendlabs:main Jun 15, 2023
@wubx
Copy link
Member

wubx commented Jun 15, 2023

cc @soyeric128 need doc

andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants