Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fine tune for background compaction #11815

Merged
merged 6 commits into from
Jun 21, 2023
Merged

Conversation

ZhiHanZ
Copy link
Collaborator

@ZhiHanZ ZhiHanZ commented Jun 20, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. background compaction would not happend if table compacted after the last update time
  2. add updated_on field for system.table and system.background_tasks.

Closes #issue

@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Jun 20, 2023 1:14pm

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jun 20, 2023
@ZhiHanZ ZhiHanZ requested a review from TCeason June 20, 2023 11:53
@ZhiHanZ
Copy link
Collaborator Author

ZhiHanZ commented Jun 20, 2023

cc @TCeason , this PR changed the create_on and drop_on field of system.tables into timestamp, PTAL if you have time, since I am not sure about whether current mysql integrations have special concerns on those fields

@TCeason
Copy link
Collaborator

TCeason commented Jun 20, 2023

cc @TCeason , this PR changed the create_on and drop_on field of system.tables into timestamp, PTAL if you have time, since I am not sure about whether current mysql integrations have special concerns on those fields

I think this is ok.

https://github.com/datafuselabs/databend/blob/0018dced004a8bc20e91716ea80747dd2b405d7d/src/query/storages/information-schema/src/tables_table.rs#L61

Now mysql intergration only will access information_schema. And only use tables.create_on as information_schema.tables.create_time.

In MySQL this field information_schema.tables.create_time type is timestamp.

// | CREATE_TIME     | timestamp                                                          | NO   |     | NULL    |       |

@BohuTANG BohuTANG merged commit a3b6850 into main Jun 21, 2023
@BohuTANG BohuTANG deleted the long-run-patch-1-zhihanz branch June 21, 2023 00:50
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
* fine tune sqls

* f

* fix

* try fix

* rollback

* neat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants