Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove disk cache when query init #11827

Merged
merged 2 commits into from
Jun 25, 2023
Merged

chore: remove disk cache when query init #11827

merged 2 commits into from
Jun 25, 2023

Conversation

lichuang
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

chore: remove disk cache when query init

Closes #issue

@vercel
Copy link

vercel bot commented Jun 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Jun 21, 2023 7:20am

@lichuang lichuang requested a review from dantengsky June 21, 2023 04:04
@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jun 21, 2023
@BohuTANG
Copy link
Member

Summary (From llmchain.rs)

  • Dependency removal The "walkdir" dependency has been removed from Cargo.lock and Cargo.toml.

  • Function removal The "get_all_files" and "recovery_from" functions have been removed from disk_cache.rs.

  • Test removal The "create_file", "test_some_existing_files", and "test_existing_file_too_large" tests have been removed from disk_cache.rs in the tests/it/providers directory.

  • Init function modification The "init" function in disk_cache.rs now removes the directory during initialization and ignores any errors that occur.

@dantengsky dantengsky merged commit df6e4b1 into databendlabs:main Jun 25, 2023
@lichuang lichuang mentioned this pull request Aug 9, 2023
Closed
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
@lichuang @andylokandy
chore: remove disk cache when query init (databendlabs#11827)
46788c0 
* chore: remove disk cache when query init

* fix: fix bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantengsky dantengsky dantengsky approved these changes

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lichuang @BohuTANG @dantengsky