Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider lazy columns when pruning unused columns. #11833

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

RinChanNOWWW
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

UnusedColumnPruner should consider lazy columns and remove them from require_columns.

Closes #11831

@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Jun 21, 2023 9:45am

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jun 21, 2023
@BohuTANG BohuTANG merged commit e8d454b into databendlabs:main Jun 21, 2023
@BohuTANG
Copy link
Member

Summary (From llmchain)

  • Improved column pruning Changes to HeuristicOptimizer and UnusedColumnPruner structs to exclude lazy columns.
  • New field added UnusedColumnPruner struct now includes apply_lazy field.
  • Exclude lazy columns in Limit operator remove_unused_columns function now excludes lazy columns when apply_lazy is true.
  • New test case Added test case in explain/ directory for SELECT statement with time range and LIMIT clause.

@RinChanNOWWW RinChanNOWWW deleted the issue-11831 branch June 21, 2023 13:07
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: select from sub query failed with error (OnQuery Error: Code: 1006, Text = Unable to get field named "1")
3 participants