Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: copy use BlockMetaInfo to pass RowBatch. #11856

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Jun 26, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

copy used to use a channel to pass row batch when there was no BlockMetaInfo, which is complicate and buggy.

Closes #10647

@vercel
Copy link

vercel bot commented Jun 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Jun 26, 2023 7:36am

@youngsofun youngsofun marked this pull request as draft June 26, 2023 04:17
@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Jun 26, 2023
@youngsofun youngsofun marked this pull request as ready for review June 26, 2023 06:49
@youngsofun
Copy link
Member Author

youngsofun commented Jun 26, 2023

flaky test #10943

@BohuTANG BohuTANG merged commit f2ffd0f into databendlabs:main Jun 26, 2023
@youngsofun youngsofun deleted the stream2 branch June 26, 2023 08:50
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
* refactor: copy use BlockMetaInfo to pass RowBatch.

* refactor: copy pipeline force resize for balance.

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: streaming load parquet got incomplete results
4 participants